Merged
Conversation
add snapshot testing backend back. New for this repository is the matplotlib snapshot extension
- use a common test document to test all backends - update bokehSnapShotExtension to be the same as massdash
modify matplotlib code for working with marginal plots
try installing using pip
refactor and add conftest file to reduce duplicate code
only 1 python version for testing purposes
remove duplicate file update to use common fixtures
update to use common fixtures
tight_layout() functionality differs slightly depending on matplotlib version, fix the version so do not have this problem.
regenerate snapshots with latest version of mpl. Ensure that the latest version of mpl is installed
remove mac os testing because plotly has slight differences
Collaborator
|
@jcharkow is this ready to merge? |
Collaborator
Author
|
This is ready to merge. If it looks good to you |
singjc
approved these changes
Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using pytest and syrupy add snapshot test for some basic plots.
Note: needed to fix the plotly and matplotlib versions because different versions generate slightly different plots.
Add github actions for automatically performing the tests