New feature: Upload logo from backend

[warleyelias]

Description (*)

This PR allows to change both header and small logos by uploading from the Backend. It is much easier than put a image on /skin folder and configure the path in Backend.

I created a validation that allows to continue using the skin image until next logo change, put a default OpenMage logo on default folder for new installation.

Manual testing scenarios (*)

1. In Backend go to System > Configurations.
2. In Design > Header section there are two new upload buttons for [Logo Image Src] and [Logo Small Image Src].
3. Upload the new images and reload the Frontend.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)
• Add yourself to contributors list

[fballiano]

thanks for you contrib, I think we already have the same PR #1068

[fballiano]

Nowadays we've multiple logos (2x, 3x, mobile, desktop) so my question is, does uploading the logo makes sense today?

[fballiano]

does this allow uploading of SVG logos?

[warleyelias]

does this allow uploading of SVG logos?

I didn't test for that file extensions but if not I can change to allow that.

[addison74]

With #1068 closed I can test this PR. @warleyelias - Please update it for SVG uploads too.

Is there any label that needs translations?

[fballiano]

I would replace the 2 bundled GIF files with just one SVG (which is probably already somewhere in the repo)

[fballiano]

actually I wouldn't bundle another logo image, I'd remove the 2 GIFs and use the SVGs that are already in the repo

[Flyingmana]

@addison74 @fballiano yes it helps, if the logo is managed by people without file access. Maybe even people who have only access to specific websites or storeviews in case of multi national organisations.

[fballiano]

Today in 2023 only having 1 single logo is never sufficient, unless it's an SVG.

The access to a single website/storeview was only available in the enterprise edition.

[Flyingmana]

The access to a single website/storeview was only available in the enterprise edition.

I know of CE shops having this, too

[fballiano]

allowing SVG upload could be more complicated than expected, because of Mage_Core_Model_File_Validator_Image::validate()

[sreichel]

Can we continue w/o SVG support?

[sreichel]

It's a feature that doesn't actually help today. I would close it like the other one.

I did not test it (yet), but if it just allows to upload logos from backend ... its a good addition imho.

[Flyingmana]

Can we continue w/o SVG support?

I would say yes, it can be added separately

[kiatng]

The Delete Image checkbox is broken

It doesn't delete the image file.

[sreichel]

Thanks for working on it :)

[kiatng]

I have no idea how to fix the PHPMD error. Other than that, I have tested the PR quite a bit, multiple uploads and deletes in various stores. No issue found.

[kiatng]

Before this PR, it's simple to use the same image file in the skin dir as the src for both the main and small logo. With this PR, even though it is BC, but if the user uploads the same image separately to both main and small logo, because the uploader is configured with setAllowRenameFiles(true), so the second upload will be renamed to avoid overwriting the first — resulting in the browser requesting 2 separate resources.

[sreichel]

@all-contributors add warleyelias code

[allcontributors]

@sreichel

I've put up a pull request to add @warleyelias! 🎉

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sreichel]

@kiatng 👍