Skip to content

[FEAT] Added Mage_Core_Observer_Interface with execute() method #4712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sreichel wants to merge 16 commits into from
Closed

[FEAT] Added Mage_Core_Observer_Interface with execute() method #4712

sreichel wants to merge 16 commits into from

Conversation

@sreichel
Copy link
Contributor

@sreichel sreichel commented Mar 16, 2025

Extracted that from #4697.

@github-actions github-actions bot added the Component: Core Relates to Mage_Core label Mar 16, 2025
@pquerner
Copy link
Contributor

pquerner commented Mar 26, 2025

Does that mean the XML structure also changes? (When you "register" a observer)

@github-actions github-actions bot added Component: Catalog Relates to Mage_Catalog Component: Cms Relates to Mage_Cms Component: Reports Relates to Mage_Reports Component: Checkout Relates to Mage_Checkout Component: Sales Relates to Mage_Sales Component: Customer Relates to Mage_Customer Component: Eav Relates to Mage_Eav Component: Adminhtml Relates to Mage_Adminhtml Component: ProductAlert Relates to Mage_ProductAlert Component: Sitemap Relates to Mage_Sitemap Component: Tag Relates to Mage_Tag Component: CatalogRule Relates to Mage_CatalogRule Component: SalesRule Relates to Mage_SalesRule Component: Wishlist Relates to Mage_Wishlist labels Apr 13, 2025
@github-actions github-actions bot added Component: Widget Relates to Mage_Widget Component: Weee Relates to Mage_Weee Component: Tax Relates to Mage_Tax Component: Review Relates to Mage_Review Component: Rating Relates to Mage_Rating Component: Payment Relates to Mage_Payment Component: Bundle Relates to Mage_Bundle Component: ConfigurableSwatches Relates to Mage_ConfigurableSwatches Component: CatalogSearch Relates to Mage_CatalogSearch Component: Rss Relates to Mage_Rss labels Apr 13, 2025
@sreichel
Copy link
Contributor Author

sreichel commented Apr 19, 2025

Does that mean the XML structure also changes? (When you "register" a observer)

There is no change in XML structure.

If the observer implements the interface, you dont need to set a method in XML, because it uses execute .

@sreichel sreichel marked this pull request as draft April 19, 2025 19:08
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 20, 2025

Quality Gate Passed Quality Gate passed

Issues
15 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.8% Duplication on New Code

See analysis details on SonarQube Cloud

@sreichel sreichel closed this Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

Component: Adminhtml Relates to Mage_Adminhtml Component: Bundle Relates to Mage_Bundle Component: Catalog Relates to Mage_Catalog Component: CatalogRule Relates to Mage_CatalogRule Component: CatalogSearch Relates to Mage_CatalogSearch Component: Checkout Relates to Mage_Checkout Component: Cms Relates to Mage_Cms Component: ConfigurableSwatches Relates to Mage_ConfigurableSwatches Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Eav Relates to Mage_Eav Component: Payment Relates to Mage_Payment Component: ProductAlert Relates to Mage_ProductAlert Component: Rating Relates to Mage_Rating Component: Reports Relates to Mage_Reports Component: Review Relates to Mage_Review Component: Rss Relates to Mage_Rss Component: Sales Relates to Mage_Sales Component: SalesRule Relates to Mage_SalesRule Component: Sitemap Relates to Mage_Sitemap Component: Tag Relates to Mage_Tag Component: Tax Relates to Mage_Tax Component: Weee Relates to Mage_Weee Component: Widget Relates to Mage_Widget Component: Wishlist Relates to Mage_Wishlist enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sreichel @pquerner