Skip to content

Remove redundant code#2489

Merged
martin-frbg merged 2 commits intoOpenMathLib:developfrom
jijiwawa:brightness
Mar 7, 2020
Merged

Remove redundant code#2489
martin-frbg merged 2 commits intoOpenMathLib:developfrom
jijiwawa:brightness

Conversation

@jijiwawa
Copy link
Copy Markdown
Contributor

@jijiwawa jijiwawa commented Mar 4, 2020

Remove redundant code in the benchmark directory

@martin-frbg
Copy link
Copy Markdown
Collaborator

That one supersedes #2487, right ? Pity I only realized this after deconflicting the older one. Need to check now that merging this would not throw out code from the others I guess...

@martin-frbg
Copy link
Copy Markdown
Collaborator

It would probably be easier if you could just resubmit this based on the current develop and with only the redundant code removed.

@jijiwawa
Copy link
Copy Markdown
Contributor Author

jijiwawa commented Mar 7, 2020

It would probably be easier if you could just resubmit this based on the current develop and with only the redundant code removed.

Resubmit done

@jijiwawa
Copy link
Copy Markdown
Contributor Author

jijiwawa commented Mar 7, 2020

That one supersedes #2487, right ?

yes

@martin-frbg
Copy link
Copy Markdown
Collaborator

Thank you.

@martin-frbg martin-frbg merged commit 14df234 into OpenMathLib:develop Mar 7, 2020
@jijiwawa jijiwawa deleted the brightness branch March 11, 2020 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants