Skip to content

Add benchmark for SPMV and fix segmentation fault when data size >= 50000#2506

Merged
martin-frbg merged 6 commits intoOpenMathLib:developfrom
xiaofengF:develop
Mar 14, 2020
Merged

Add benchmark for SPMV and fix segmentation fault when data size >= 50000#2506
martin-frbg merged 6 commits intoOpenMathLib:developfrom
xiaofengF:develop

Conversation

@xiaofengF
Copy link
Copy Markdown

Add benchmark for SPMV and fix segmentation fault when data size >= 50000

@martin-frbg
Copy link
Copy Markdown
Collaborator

I'm beginning to suspect that it is actually a long-standing error in our version of the LAPACK Makefile. xSPMV is overloaded with an OpenBLAS implementation from driver/level2 so the original fortran version from the reference implementation needs to be excluded from the build.

@xiaofengF
Copy link
Copy Markdown
Author

I'm beginning to suspect that it is actually a long-standing error in our version of the LAPACK Makefile. xSPMV is overloaded with an OpenBLAS implementation from driver/level2 so the original fortran version from the reference implementation needs to be excluded from the build.

But I can't understand why the fortran version doesn't affect others, but only the cspmv and zspmv.

@xiaofengF
Copy link
Copy Markdown
Author

I'm beginning to suspect that it is actually a long-standing error in our version of the LAPACK Makefile. xSPMV is overloaded with an OpenBLAS implementation from driver/level2 so the original fortran version from the reference implementation needs to be excluded from the build.

Maybe you can first pull the benchmark addition for sspmv and dspmv, because openblas only have s/d spmv in the cblas.h. c/z spmv is not that important.

@martin-frbg
Copy link
Copy Markdown
Collaborator

Comparing with the reference implementation, it is indeed only SSPMV and DSPMV that are in BLAS (and consequently CBLAS), while CSPMV and ZSPMV are LAPACK auxiliaries that do not even have a LAPACKE interface for them. Probably some "historic" reason for this distinction...

@martin-frbg martin-frbg merged commit c0649aa into OpenMathLib:develop Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants