[OpenBLAS]:fix the iamax benchmark error#2508
[OpenBLAS]:fix the iamax benchmark error#2508martin-frbg merged 1 commit intoOpenMathLib:developfrom
Conversation
[Description]:the result for i?amax is not MFlops, it is MBytes
|
the CI problem that miss the gfortran comand was fixed, and the i?amax code changed commit pass. |
|
Technically you are right, of course. But I wonder which of the two units is more confusing - probably the expectation is MFlops, and the number of bytes seems to be just an easy-to-obtain proxy value for the actual number of comparisons performed per unit time ? |
|
I think both "MFlops" and "Bytes" are reasonable units to judge the performance once all your test cases just use the one of them. but there is a situation I encounter that this benchmark give me some confusion. since I know the peak MFlops value in my platform, this L1 benchmark just print the MFlops number greater than the theoritical limit(because of the extra sizeof(FLOAT) multiplication), which is impossible. so I read the source code and found the print is not rigorous to this case and made this commit |
|
Makes perfect sense, thanks |
[Description]:the result for i?amax is not MFlops, it is MBytes