Skip to content

[OpenBLAS]:fix the iamax benchmark error#2508

Merged
martin-frbg merged 1 commit intoOpenMathLib:developfrom
liujingjue:develop
Mar 14, 2020
Merged

[OpenBLAS]:fix the iamax benchmark error#2508
martin-frbg merged 1 commit intoOpenMathLib:developfrom
liujingjue:develop

Conversation

@liujingjue
Copy link
Copy Markdown
Contributor

[Description]:the result for i?amax is not MFlops, it is MBytes

[Description]:the result for i?amax is not MFlops, it is MBytes
@liujingjue
Copy link
Copy Markdown
Contributor Author

the CI problem that miss the gfortran comand was fixed, and the i?amax code changed commit pass.
iamax benchmark test the show the capability of "MBytes" not "MFlops" which makes user confused because the number shown usually passes the peak of the calculation

@martin-frbg
Copy link
Copy Markdown
Collaborator

Technically you are right, of course. But I wonder which of the two units is more confusing - probably the expectation is MFlops, and the number of bytes seems to be just an easy-to-obtain proxy value for the actual number of comparisons performed per unit time ?

@liujingjue
Copy link
Copy Markdown
Contributor Author

I think both "MFlops" and "Bytes" are reasonable units to judge the performance once all your test cases just use the one of them. but there is a situation I encounter that this benchmark give me some confusion. since I know the peak MFlops value in my platform, this L1 benchmark just print the MFlops number greater than the theoritical limit(because of the extra sizeof(FLOAT) multiplication), which is impossible. so I read the source code and found the print is not rigorous to this case and made this commit

@martin-frbg
Copy link
Copy Markdown
Collaborator

Makes perfect sense, thanks

@martin-frbg martin-frbg merged commit c284099 into OpenMathLib:develop Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants