Further shortcuts for (small) cases that do not need buffer allocation#3252
Merged
martin-frbg merged 4 commits intoOpenMathLib:developfrom Jun 15, 2021
martin-frbg:more_shortcuts
Merged
Further shortcuts for (small) cases that do not need buffer allocation#3252martin-frbg merged 4 commits intoOpenMathLib:developfrom martin-frbg:more_shortcuts
martin-frbg merged 4 commits intoOpenMathLib:developfrom
martin-frbg:more_shortcuts
Conversation
martin-frbg
added a commit
that referenced
this pull request
Oct 20, 2021
Revert wrong ZTRSV optimization from #3252
martin-frbg
added a commit
that referenced
this pull request
Oct 25, 2021
Revert invalid trsv shortcut from PR #3252
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For problem sizes that are too small to benefit from multithreading, we can also skip the locking-intensive allocation and freeing of a temporary buffer if the data does not need compacting or sorting. This PR speeds up the single and double precision real versions of GER, SPR, SPR2, SYR2 and TRSV as well as the single and double precision complex versions of SYR and TRSV.
On x86_64, the same method should be applcable to SYMV as none of the present kernels make use of the buffer array under these circumstances, but this does not hold for all architectures.