Rework MIPS MSA capability detection/handling#3880
Merged
martin-frbg merged 3 commits intoOpenMathLib:developfrom Jan 3, 2023
martin-frbg:rework_msa
Merged
Rework MIPS MSA capability detection/handling#3880martin-frbg merged 3 commits intoOpenMathLib:developfrom martin-frbg:rework_msa
martin-frbg merged 3 commits intoOpenMathLib:developfrom
martin-frbg:rework_msa
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings definitions in line with other platforms - HAVE_MSA now denotes the cpu feature, NO_MSA the (in)ability of the compiler or other environment to use it. This also fixes a latent bug exposed by my #3875 , which broke the build for MIPS1004K and related due to wrong choice of GEMM kernels