Skip to content

fix typo#3886

Merged
martin-frbg merged 1 commit intoOpenMathLib:developfrom
uniontech-lilinjie:develop
Jan 21, 2023
Merged

fix typo#3886
martin-frbg merged 1 commit intoOpenMathLib:developfrom
uniontech-lilinjie:develop

Conversation

@uniontech-lilinjie
Copy link
Copy Markdown
Contributor

Signed-off-by: lilinjie lilinjie@uniontech.com
fix typo

Signed-off-by: lilinjie <lilinjie@uniontech.com>
@martin-frbg
Copy link
Copy Markdown
Collaborator

Thanks - this is actually "historic" documentation from the original GotoBLAS project, not sure we even want to touch it.

@Mousius
Copy link
Copy Markdown
Contributor

Mousius commented Jan 12, 2023

@martin-frbg what would be the best approach to tidying this up?

@martin-frbg
Copy link
Copy Markdown
Collaborator

@Mousius I am questioning if this needs tidying up at all. Maybe these old docs need to be moved to their own directory, and a unified set of documentation created (e.g. integrating parts of the gh wiki)

@Mousius
Copy link
Copy Markdown
Contributor

Mousius commented Jan 12, 2023

@Mousius I am questioning if this needs tidying up at all. Maybe these old docs need to be moved to their own directory, and a unified set of documentation created (e.g. integrating parts of the gh wiki)

That's what I was getting at, if they're not useful and we're not maintaining them we could just remove them? Git history will preserve them 😸

@martin-frbg
Copy link
Copy Markdown
Collaborator

Removing them is a bit much I think, especially as they serve as a reminder of the GotoBLAS heritage - at least it irks me when people assume or even claim that OpenBLAS was created from scratch in 2010, when it really is just a continuation of a much older work that had quite an impact in its time.

@Mousius
Copy link
Copy Markdown
Contributor

Mousius commented Jan 12, 2023

Removing them is a bit much I think, especially as they serve as a reminder of the GotoBLAS heritage - at least it irks me when people assume or even claim that OpenBLAS was created from scratch in 2010, when it really is just a continuation of a much older work that had quite an impact in its time.

Isn't the initial line in the README enough to inform people? Could also add a Heritage section or similar? It worries me that this contribution is here because of the confusion introduced by retaining the older files.

@martin-frbg martin-frbg merged commit 6c1076e into OpenMathLib:develop Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants