Fix USE_PERL option usage#3896
Merged
martin-frbg merged 1 commit intoOpenMathLib:developfrom Feb 2, 2023
Merged
Conversation
Once you define the USE_PERL variable it is always set as DEFINED regardless of its value. One should chack for the actual variable value.
Collaborator
|
Thanks, one more for the "nobody will ever set this to zero instead of leaving it unmentioned" gallery |
Contributor
Author
|
It is already set to OFF a few lines above, so there is currently no way to reach the "no perl" code path |
Collaborator
|
Ah, ok, I'd wondered how I missed it - but in that case it was more like an overcorrection |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once you define the USE_PERL variable it is always set as DEFINED regardless of its value. One should chack for the actual variable value.