fix conlict between PR 4515 and AIX shared obj support#4520
Merged
martin-frbg merged 1 commit intoOpenMathLib:developfrom Feb 23, 2024
Merged
fix conlict between PR 4515 and AIX shared obj support#4520martin-frbg merged 1 commit intoOpenMathLib:developfrom
martin-frbg merged 1 commit intoOpenMathLib:developfrom
Conversation
Contributor
|
@martin-frbg This needs to be included in 0.3.27 |
Collaborator
|
right, forgot the milestone tag but it is primarily for drafting the changelog anyway - anything in the develop branch at the time of release creation will normally end up in the release, can't recall this ever having been different |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 4515 (removing second_ and dsecnd_ from IBM xlf builds) and the changes to enable AIX shared object support were delivered on the same day and were not tested together. second_ and dsecnd_ must also be conditionally removed from linktest.c, used to verify the shared object build, and that is the purpose of this change. The change was made in exports/Makefile because the F_COMPILER make variable is available there.