Accelerate SVE128 SBGEMM/BGEMM#5667
Merged
martin-frbg merged 1 commit intoOpenMathLib:developfrom Mar 6, 2026
Merged
Conversation
This accelerates SBGEMM/BGEMM by extending the existing 8x4 kernel to 8x8 (unrolling N by 8) Not sure if it's a good idea to delete the previous 8x4 kernel? Here are the speedups on single core Neoverse-V2 (SVE128) compared to prev state: Per-shape speedup M=N=K=64: SBGEMM 1.164x (16.42%), BGEMM 1.133x (13.30%) M=N=K=128: SBGEMM 1.220x (22.02%), BGEMM 1.186x (18.56%) M=N=K=256: SBGEMM 1.241x (24.08%), BGEMM 1.235x (23.54%) M=N=K=512: SBGEMM 1.240x (23.95%), BGEMM 1.227x (22.75%) M=N=K=1024: SBGEMM 1.251x (25.11%), BGEMM 1.232x (23.23%) M=N=K=2048: SBGEMM 1.235x (23.47%), BGEMM 1.246x (24.64%) Signed-off-by: Fadi Arafeh <fadi.arafeh@arm.com>
Contributor
Author
|
Hi @martin-frbg - could you please have a look? (This currently copies the 8x4 kernel and extends it to 8x8 - please let me know if it's a good idea to remove the 8x4 kernel) |
Collaborator
|
Looks good to me, thanks. And I still think it makes sense to leave older kernels around, even if nothing uses them at the moment - they might still turn out to be adequate (or at least provide inspiration for kernels) for other cpus (or data types) that do not benefit from the latest enhancement or unrolling pattern |
Contributor
Author
|
thanks for reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This accelerates SBGEMM/BGEMM by extending the existing 8x4 kernel to 8x8 (unrolling N by 8)
Not sure if it's a good idea to delete the previous 8x4 kernel?
Here are the speedups on single core Neoverse-V2 (SVE128) compared to prev state:
and here are the speedups for the same benchmark on Neoverse-N2: