Fix DROUNDUP_LWORK: patch was not fully copied#5753
Merged
martin-frbg merged 1 commit intoOpenMathLib:developfrom Apr 9, 2026
Merged
Fix DROUNDUP_LWORK: patch was not fully copied#5753martin-frbg merged 1 commit intoOpenMathLib:developfrom
martin-frbg merged 1 commit intoOpenMathLib:developfrom
Conversation
This was referenced Apr 9, 2026
Collaborator
|
Oops, not sure what happened to #5702 - there appear to be similar differences in the related complex routines. (One of those silly situations where I abused the web interface for PR creating instead of pushing from a local repo due to travelling) |
Contributor
Author
|
Remaining files are OK. |
Collaborator
|
I'm seeing differences in chegvd.f (roundup not used on RWORK(1) in line 322 between a fresh checkout of both OpenBLAS and Reference-LAPACK, and also for the other c & z files from 1203/5702 |
Collaborator
|
Absolutely no idea right now how #5702 ended up with a partial commit of the fixes from 1203, as I had copied the entire files from an up-to-date checkout of Reference , no manual edits... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asm before fix: https://godbolt.org/z/dzoTvaoTq
The most interesting lines are 153-154:
Here,
droundup_lwork_sets d0 register based on integer value in x0 register. Then,fcvtsetsd0fp64 register with value froms0fp32 register. However, s0 was set to zero (and, actually, never used), so, after this, d0 is 0.0 that breaks computing of memory requirement.Asm after fix: https://godbolt.org/z/MW4rvoETa
Only these two files are affected.
Bug was introduced by commit 99c1209 (PR #5702)
Fixes #5754