Skip to content

Fix ARM64 DYNAMIC_ARCH unconditionally branching into the SME code for STRMM #5767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martin-frbg merged 3 commits into from
Apr 22, 2026
+3 −6
Merged

Fix ARM64 DYNAMIC_ARCH unconditionally branching into the SME code for STRMM #5767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7448679
Move quick return out of the scope of the DYNAMIC_ARCH conditional fo…
martin-frbg Apr 22, 2026
fd862d4
Remove redundant quick return
martin-frbg Apr 22, 2026
59cfea0
Move quick return out of the scope of the potential DYNAMIC_ARCH check
martin-frbg Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions interface/symm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,7 @@ void CNAME(enum CBLAS_ORDER order, enum CBLAS_SIDE Side, enum CBLAS_UPLO Uplo,
return;
}

if (args.m == 0 || args.n == 0) return;
#if !defined(COMPLEX) && !defined(DOUBLE) && !defined(BFLOAT16) && !defined(HFLOAT16)
#if defined(ARCH_ARM64) && (defined(USE_SSYMM_KERNEL_DIRECT)||defined(DYNAMIC_ARCH))
#if defined(DYNAMIC_ARCH)
Expand All @@ -383,7 +384,6 @@ if (strcmp(gotoblas_corename(), "armv9sme") == 0
#endif
)
#endif
if (args.m == 0 || args.n == 0) return;
if (order == CblasRowMajor && m == lda && n == ldb && n == ldc)
{
if (Side == CblasLeft && Uplo == CblasUpper) {
Expand All @@ -398,8 +398,6 @@ if (strcmp(gotoblas_corename(), "armv9sme") == 0

#endif

if (args.m == 0 || args.n == 0) return;

IDEBUG_START;

FUNCTION_PROFILE_START();
Expand Down
5 changes: 2 additions & 3 deletions interface/trsm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,6 +359,8 @@ void CNAME(enum CBLAS_ORDER order,
return;
}

if (args.m == 0 || args.n == 0) return;

#if !defined(COMPLEX) && !defined(DOUBLE) && !defined(BFLOAT16) && !defined(HFLOAT16)
#if defined(ARCH_ARM64) && (defined(USE_STRMM_KERNEL_DIRECT)||defined(DYNAMIC_ARCH))
#if defined(DYNAMIC_ARCH)
Expand All @@ -368,7 +370,6 @@ if (strcmp(gotoblas_corename(), "armv9sme") == 0
#endif
)
#endif
if (args.m == 0 || args.n == 0) return;
if (order == CblasRowMajor && Diag == CblasNonUnit && Side == CblasLeft && m == lda && n == ldb) {
if (Trans == CblasNoTrans) {
(Uplo == CblasUpper ? STRMM_DIRECT_LNUN : STRMM_DIRECT_LNLN)(m, n, alpha, a, lda, b, ldb);
Expand All @@ -382,8 +383,6 @@ if (strcmp(gotoblas_corename(), "armv9sme") == 0

#endif

if ((args.m == 0) || (args.n == 0)) return;

IDEBUG_START;

FUNCTION_PROFILE_START();
Expand Down
Loading