You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This change creates a significant mismatch in the codspeed test that uses dgesdd - not sure if it is safe to increase our tolerance there (as the same repercussions might occur in numpy etc), or if I should raise this with the LAPACK team. @rgommers ?
(thought I had already added this comment last night but somehow it didn't post - apologies if you see it twice)
I wouldn't particularly worry about numpy here, since if it's valid to bump tolerances here then it's equally valid to do so in the numpy test suite. However, the errors seems a bit large to me. For a size (1000, 222) array filled with random floats, the test tolerances were rtol=1e-07, atol=1e-05, and this isn't just a small increase:
E Max absolute difference among violations: 2.336502e-05
E Max relative difference among violations: 0.01933236
I don't see any discussion in Reference-LAPACK/lapack#1286 or in the linked issue it closes that that's expected - so probably worth checking?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.