Feat add simple paths provider test#1598
Merged
openminddev merged 7 commits intoOpenMind:mainfrom Jan 19, 2026
Merged
Conversation
…ring fix: disable ruff import sorting (I) to avoid conflict with isort - Ruff and isort have conflicting rules about blank lines between imports - Disabled ruff's I rule since isort (with black profile) is already configured
github-actions
Bot
added
dependencies
Removed redundant comments and streamlined test code in test_simple_paths_provider.py. Updated import path for SimplePathsProvider and improved fixture clarity. The changes make the tests more concise and easier to maintain without altering test logic.
Updated the [dependency-groups] dev section in pyproject.toml to use exact versions for black, isort, pre-commit, pyright, pytest, pytest-asyncio, ruff, and vulture. Synchronized uv.lock to match these versions and removed unnecessary or outdated dependencies. This ensures consistent development environments and reproducible builds.
Adds type: ignore to certain imports and updates pyright to 1.1.408. Refactors function call extraction in LLM plugins to use getattr for better compatibility. Improves error handling in face emotion detection and adds an assertion in a test to ensure image decoding. Fixes angle flipping in RPLidar provider to ensure correct data type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds unit tests for the
_generate_movement_stringmethod insrc/providers/simple_paths_provider.py. Additionally, it resolves a conflict betweenruffandisortpre-commit hooks that was causing commit failures or infinite loops.Type of change
Changes
tests/providers/test_simple_paths_provider.pywith unit tests for_generate_movement_string.pyproject.tomlto removeruff's import sorting rules (I), preventing conflicts withisort.Impact
The primary impact is an improvement in code quality and reliability through increased test coverage for the
SimplePathsProvider. The secondary impact is a fix to the development workflow by resolving theruff/isortconflict in pre-commit hooks, leading to smoother commits.Additional Information
The
ruffconfiguration change inpyproject.tomldisables its import sorting capabilities (select = ["E", "F", "D"]instead of including "I"). This allowsisortto manage import order exclusively, avoiding potential disagreements between the two tools on import organization.