add-unit-test-ethereum-governance#1827
Merged
openminddev merged 2 commits intoOpenMind:mainfrom Jan 26, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the unit tests for the
GovernanceEthereuminput plugin located insrc/inputs/plugins/ethereum_governance.py.load_rules_from_blockchainby mocking thedecode_eth_responsefunction to avoid complex ABI hex input issues.decode_eth_responseto focus on error handling paths that can be reliably tested (e.g., invalid hex input causingbytes.fromhexto fail).rpc_urlvalue.decode_eth_responsefunction's ABI parsing logic (see linked issue).The original test cases attempting to validate specific decoded strings proved unreliable due to the complexity of crafting correct ABI-encoded hex input manually. The focus shifts to testing the overall flow and error handling.