Update om1-modules dependency and enhance ASR provider logging#2546
Merged
Conversation
github-actions
Bot
added
dependencies
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the pinned om1-modules dependency and improves ASR shutdown observability/cleanup by adding a “stopped” log to the ASR provider and stopping the ASR engine when the Google ASR input session is closed.
Changes:
- Bump
om1-modulesgit revision inpyproject.tomlanduv.lock. - Add an “ASR provider stopped” log line in
ASRProvider.stop(). - Extend
GoogleASRInput.stop()to stop the underlyingASRProvider.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| uv.lock | Updates locked om1-modules git revision to match dependency bump. |
| pyproject.toml | Bumps om1-modules git revision. |
| src/providers/asr_provider.py | Adds info log when provider stops (observability). |
| src/inputs/plugins/google_asr.py | Ensures ASR provider is stopped during plugin shutdown (cleanup). |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
…nhance face presence detection with closest name identification
Add support for a closest_name field in PresenceSnapshot text output and update related tests and inputs to include the "Closest: <name>." suffix. Adjust tests in providers and TTS connector to use the new camera-format strings and update expected unknown counts. Also tidy imports and formatting in face_presence_provider and apply a minor whitespace cleanup in greeting_hook.py.
Introduce comprehensive tests for greeting_start_hook: add AsyncMock import, new mock_face_presence_provider fixture, and many test cases covering ElevenLabs, Kokoro, Riva providers, custom parameters, face detection variants, logging, error paths, and return value expectations. Update geeting_end_hook tests to assert and check return values, add additional error/state/logging scenarios and success checks. Also make small test cleanup in face_presence_provider tests (add type: ignore on prefer_recent assignments and remove separator comment). These changes increase coverage and validate success/failure return behavior for greeting hooks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to dependencies and improvements to resource cleanup and logging in the ASR (Automatic Speech Recognition) components. The most important changes are grouped below:
Dependency Updates:
om1-modulesdependency inpyproject.tomlto a newer commit, ensuring the latest module changes are included.ASR Component Improvements:
src/providers/asr_provider.py, added a logging statement to indicate when the ASR provider has stopped, improving observability.src/inputs/plugins/google_asr.py, ensured that the ASR engine is properly stopped when the session is closed, enhancing resource cleanup