Increase default max_turn_count to 5#2554
Merged
Merged
Conversation
Update GreetingConversationStateMachineProvider.__init__ to use a default max_turn_count of 5 instead of 3 and add a brief docstring documenting the initializer and the max_turn_count parameter. This increases the allowed number of conversational turns before forcing a transition to finished; no other logic changes were made.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the greeting conversation state machine provider to allow a longer default conversation before forcing a transition to FINISHED, and documents the initializer parameter.
Changes:
- Increase
GreetingConversationStateMachineProvider.__init__defaultmax_turn_countfrom 3 to 5. - Add a NumPy-style docstring to
__init__documentingmax_turn_count.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Prachi1615
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update GreetingConversationStateMachineProvider.init to use a default max_turn_count of 5 instead of 3 and add a brief docstring documenting the initializer and the max_turn_count parameter. This increases the allowed number of conversational turns before forcing a transition to finished; no other logic changes were made.