Skip to content

Add bindings for base/percentile#116

Merged
chinmayshah99 merged 2 commits intoOpenMined:devfrom
alejandrosame:feature/percentile
Apr 29, 2020
Merged

Add bindings for base/percentile#116
chinmayshah99 merged 2 commits intoOpenMined:devfrom
alejandrosame:feature/percentile

Conversation

@alejandrosame
Copy link
Copy Markdown
Member

@alejandrosame alejandrosame commented Apr 28, 2020 •
edited
Loading

Description

This PR adds python bindings for file base/percentile.h

Fixes #10

Type of change

Please mark options that are relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Did you run make test-all? Yes

Checklist:

  • New Unit tests added
  • Unit tests pass locally with my changes

jeamick
jeamick reviewed Apr 28, 2020
View reviewed changes
Comment thread src/bindings/PyDP/base/percentile.cpp Outdated
@@ -0,0 +1,27 @@
// Provides bindings for perentile class
Copy link
Copy Markdown
Member

@jeamick jeamick Apr 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// Provides bindings for percentile class

Copy link
Copy Markdown
Member

@jeamick jeamick Apr 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

Copy link
Copy Markdown
Member Author

@alejandrosame alejandrosame Apr 28, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Fixed on the last commit

jeamick
jeamick previously approved these changes Apr 28, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@jeamick jeamick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds ok to me !! ;)

chinmayshah99
chinmayshah99 approved these changes Apr 29, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@chinmayshah99 chinmayshah99 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we have classes declared as PercentileInt() and PercentileDouble(), we need towards a strategy so that we just call Percentile() and type of datatype is given in function argument.

@chinmayshah99 chinmayshah99 merged commit 69eaa66 into OpenMined:dev Apr 29, 2020
@alejandrosame alejandrosame deleted the feature/percentile branch August 15, 2020 09:38
dvadym pushed a commit to dvadym/PyDP that referenced this pull request Jul 3, 2022
@zachferr
Implement the new count field in the mechanism_spec. (OpenMined#116)
97bb03d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chinmayshah99 chinmayshah99 chinmayshah99 approved these changes

+1 more reviewer

@jeamick jeamick jeamick left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

base\percentile

3 participants

@alejandrosame @chinmayshah99 @jeamick