Skip to content

Add bindings for algorithms/count#122

Merged
chinmayshah99 merged 1 commit intoOpenMined:devfrom
alejandrosame:feature/algorihtms-count
May 3, 2020
Merged

Add bindings for algorithms/count#122
chinmayshah99 merged 1 commit intoOpenMined:devfrom
alejandrosame:feature/algorihtms-count

Conversation

@alejandrosame
Copy link
Copy Markdown
Member

Description

This PR adds python bindings for file algorithms/count.h. After different iterations, the approach used here is to provide custom code execution through C++ anonymous functions.

Fixes #22

Type of change

Please mark options that are relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Did you run make test-all? Yes

Checklist:

  • New Unit tests added
  • Unit tests pass locally with my changes

@chinmayshah99
Copy link
Copy Markdown
Member

This is lambda function approach is interesting. As discussed, we will take a call on what approach we should take by our weekly team call.

@chinmayshah99 chinmayshah99 merged commit 24dfc82 into OpenMined:dev May 3, 2020
@alejandrosame alejandrosame deleted the feature/algorihtms-count branch August 15, 2020 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

algorithms\count

2 participants