Algorithm rand bindings#123
Merged
chinmayshah99 merged 15 commits intoOpenMined:devfrom May 7, 2020
Merged
Conversation
Link Pybind Introduction
Added pybind11 tutorial.
chinmayshah99
requested changes
May 3, 2020
Contributor
Author
|
Ok, I've added instance checks to everything currently binded except utils. For some reason to import it, it has to be "import pydp.pydp.util" which I don't think is intended. |
alejandrosame
previously approved these changes
May 5, 2020
Member
alejandrosame
left a comment
alejandrosame
left a comment
There was a problem hiding this comment.
I approve the PR, but I want to raise awareness that it is bad practice to make PRs (and generally group commits) that span files unrelated to the feature that the PR targets.
In this case, the addition of isinstance tests for the other classes should be made in a separate PR to make the scope clearer. It's not critical at all right now, but at some point I expect that we will need to reinforce this kind of workflows.
chinmayshah99
requested changes
May 6, 2020
dvadym
pushed a commit
to dvadym/PyDP
that referenced
this pull request
Jul 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Binds algorithms/rand to pydp.
Please mark options that are relevant.
How Has This Been Tested?
I ran build PyDP.sh, ran python on my terminal:
import pydp as dp
dp.Geometric()
dp.UniformDouble()
Numbers matched what rand.h indicates they should be.