Skip to content

Fix docker build error#131

Merged
chinmayshah99 merged 2 commits intoOpenMined:devfrom
chinmayshah99:bug/docker-fix
May 8, 2020
Merged

Fix docker build error#131
chinmayshah99 merged 2 commits intoOpenMined:devfrom
chinmayshah99:bug/docker-fix

Conversation

@chinmayshah99
Copy link
Copy Markdown
Member

Description

fixed the file overwrite(duplicate .git file) issue and package name issue.

Fixes #124

Partial issue # (issue)

Type of change

Please mark options that are relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Did you run make test-all?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • New Unit tests added
  • Unit tests pass locally with my changes

fixed the file overwrite(duplicate .git file) issue and package name issue.
@chinmayshah99 chinmayshah99 requested a review from replomancer May 6, 2020 21:08
@replomancer
Copy link
Copy Markdown
Member

Yes, it builds for me now.

Only this part of building output looks wrong:

Step 10/12 : RUN if [[-d "/root/PyDP/third_party/differential-privacy"] && -d "/root/PyDP/third_party/pybind11_bazel"];         then echo "";     else echo "removed" &&         rm -rf third_party/differential-privacy/ third_party/pybind11_bazel/ &&         cp -r /tmp/third_party/* /root/PyDP/third_party/ ;     fi
 ---> Running in 07635af9e7d2
removed
/bin/sh: 1: [[-d: not found

This results from Docker using /bin/sh instead of /bin/bash ([[ syntax is not supported).

@chinmayshah99
Copy link
Copy Markdown
Member Author

Are you sure that's a syntax error?
Because it's going in the else segment

@chinmayshah99
Copy link
Copy Markdown
Member Author

@replomancer I have fixed that bug.
Apparently Docker uses bourne shell rather than bash which caused this command to fail.

Copy link
Copy Markdown
Member

@replomancer replomancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chinmayshah99 chinmayshah99 merged commit 360e54b into OpenMined:dev May 8, 2020
@chinmayshah99 chinmayshah99 deleted the bug/docker-fix branch May 8, 2020 09:32
dvadym added a commit to dvadym/PyDP that referenced this pull request Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docker image doesn't build

2 participants