Skip to content

Made carrots demo py3.5 compatible#139

Merged
chinmayshah99 merged 1 commit intoOpenMined:devfrom
chinmayshah99:python35-support
May 11, 2020
Merged

Made carrots demo py3.5 compatible#139
chinmayshah99 merged 1 commit intoOpenMined:devfrom
chinmayshah99:python35-support

Conversation

@chinmayshah99
Copy link
Copy Markdown
Member

Description

As @replomancer pointed out, carrots demo is not python 3.5 compatible. Fixed that!

Fixes #138

Partial issue # (issue)

Type of change

Please mark options that are relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Did you run make test-all?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • New Unit tests added
  • Unit tests pass locally with my changes

@chinmayshah99 chinmayshah99 requested a review from replomancer May 11, 2020 08:20
Copy link
Copy Markdown
Member

@replomancer replomancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! 👍

@chinmayshah99 chinmayshah99 merged commit 5af616a into OpenMined:dev May 11, 2020
@chinmayshah99 chinmayshah99 deleted the python35-support branch May 28, 2020 14:08
dvadym pushed a commit to dvadym/PyDP that referenced this pull request Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port carrots.py to python 3.5.9

2 participants