added c++17 flag#145
Merged
chinmayshah99 merged 2 commits intoOpenMined:devfrom May 17, 2020
Merged
Conversation
statusor2 needs to be worked on further
Member
|
This change doesn't fix #144 on Ubuntu 20.04. I get the same error messages as before. |
Member
Author
|
I mentioned it as Partial fix since I suspected maybe adding c++17 will do away with some errors. But seems like it doesn't. Without adding c++17 flag, I was not able to build the code on my Ubuntu 18.04 system. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After the latest code push by google, they started using c++17 which caused our code to break. Fixed that process.
Fixes # (issue)
Partial issue #
Type of change
Please mark options that are relevant.
How Has This Been Tested?
Did you run
make test-all?Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: