Skip to content

added c++17 flag#145

Merged
chinmayshah99 merged 2 commits intoOpenMined:devfrom
chinmayshah99:bugfix/google-update
May 17, 2020
Merged

added c++17 flag#145
chinmayshah99 merged 2 commits intoOpenMined:devfrom
chinmayshah99:bugfix/google-update

Conversation

@chinmayshah99
Copy link
Copy Markdown
Member

@chinmayshah99 chinmayshah99 commented May 16, 2020

Description

After the latest code push by google, they started using c++17 which caused our code to break. Fixed that process.

Fixes # (issue)

Partial issue #

Type of change

Please mark options that are relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Did you run make test-all?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • bazel build successful
  • Test B

Checklist:

  • New Unit tests added
  • Unit tests pass locally with my changes

@chinmayshah99 chinmayshah99 changed the title making code work after latest google codepush added c++17 flag May 16, 2020
statusor2 needs to be worked on further
@replomancer
Copy link
Copy Markdown
Member

This change doesn't fix #144 on Ubuntu 20.04. I get the same error messages as before.

@chinmayshah99
Copy link
Copy Markdown
Member Author

I mentioned it as Partial fix since I suspected maybe adding c++17 will do away with some errors. But seems like it doesn't.

Without adding c++17 flag, I was not able to build the code on my Ubuntu 18.04 system.

@chinmayshah99 chinmayshah99 merged commit 45ea101 into OpenMined:dev May 17, 2020
@chinmayshah99 chinmayshah99 deleted the bugfix/google-update branch May 17, 2020 18:30
@Frank-7 Frank-7 requested review from Frank-7 and removed request for Frank-7 June 1, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants