Fix a namespace in logging.cpp#146
Merged
chinmayshah99 merged 1 commit intoOpenMined:devfrom May 17, 2020
replomancer:logging_build_fix
Merged
Fix a namespace in logging.cpp#146chinmayshah99 merged 1 commit intoOpenMined:devfrom replomancer:logging_build_fix
chinmayshah99 merged 1 commit intoOpenMined:devfrom
replomancer:logging_build_fix
Conversation
chinmayshah99
approved these changes
May 17, 2020
dvadym
pushed a commit
to dvadym/PyDP
that referenced
this pull request
Jul 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hey,
This small change fixes #144
I don't understand the whole story here but:
std::stringnotstd::__cxx11::string,__cxx11appears,test_logging.pyhave been failing for a while),__cxx11from here fixes the building process (issue logging.cpp causing build error #144).Type of change
Please mark options that are relevant.
How Has This Been Tested?
Running
./build_PyDP.shon Ubuntu 20.04 ends with error and this change fixes that. Building the Docker image succeeds regardless of the change (base image is python:3.6-slim-buster).