Updated contributing.md and tested prereqs_mac.sh#155
Merged
iamtrask merged 1 commit intoOpenMined:madhavajay/macosfrom May 29, 2020
Merged
Updated contributing.md and tested prereqs_mac.sh#155iamtrask merged 1 commit intoOpenMined:madhavajay/macosfrom
iamtrask merged 1 commit intoOpenMined:madhavajay/macosfrom
Conversation
Contributor
madhavajay
commented
May 25, 2020
- Fixed pydp.so cleanup before new build
- Fixed pydp.so cleanup before new build
| # echo "Donwloading and installing Python3 homebrew" | ||
| # brew install python | ||
| echo "Downloading and installing Python3 using homebrew" | ||
| brew install python3 |
Member
There was a problem hiding this comment.
Commented this out, because there can be conflicts. So we need to check if python is already installed, then skip this part.
iamtrask
approved these changes
May 29, 2020
dvadym
pushed a commit
to dvadym/PyDP
that referenced
this pull request
Jul 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.