Skip to content

Update style_check.yml#156

Merged
chinmayshah99 merged 1 commit intoOpenMined:devfrom
codeboy5:dev
May 26, 2020
Merged

Update style_check.yml#156
chinmayshah99 merged 1 commit intoOpenMined:devfrom
codeboy5:dev

Conversation

@codeboy5
Copy link
Copy Markdown
Member

Split the style tests as discussed in the issue #125

Pull Request

Description

Please include a summary of the change and which issue is fixed. If this closes one or more open issues, please tag them as described here.

Affected Dependencies

List any dependencies that are required for this change.

Type of Change

Please mark options that are relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation (non-breaking change which adds documentation)
  • Improvement (non-breaking change that improves the performance or reliability of existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

Additional Context

Please also include relevant motivation and context.

split the style tests
@chinmayshah99 chinmayshah99 requested a review from Benardi May 26, 2020 06:16
@chinmayshah99
Copy link
Copy Markdown
Member

Just to verify, if the python test fails, would the CPP one run?

@codeboy5
Copy link
Copy Markdown
Member Author

Just to verify, if the python test fails, would the CPP one run?

Yes I tested it on my local repo.
https://github.com/codeboy5/PyDP/runs/709155912?check_suite_focus=true

Copy link
Copy Markdown
Member

@chinmayshah99 chinmayshah99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chinmayshah99 chinmayshah99 merged commit 07a1097 into OpenMined:dev May 26, 2020
dvadym pushed a commit to dvadym/PyDP that referenced this pull request Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants