Skip to content

fix_test_logging_typo#157

Merged
chinmayshah99 merged 2 commits intoOpenMined:devfrom
systemshift:test_logging_typo
May 26, 2020
Merged

fix_test_logging_typo#157
chinmayshah99 merged 2 commits intoOpenMined:devfrom
systemshift:test_logging_typo

Conversation

@systemshift
Copy link
Copy Markdown
Contributor

Pull Request

Description

Please include a summary of the change and which issue is fixed. If this closes one or more open issues, please tag them as described here.

Affected Dependencies

List any dependencies that are required for this change.

Type of Change

Please mark options that are relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation (non-breaking change which adds documentation)
  • Improvement (non-breaking change that improves the performance or reliability of existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

Additional Context

Please also include relevant motivation and context.

Copy link
Copy Markdown
Member

@chinmayshah99 chinmayshah99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change all pd to dp?
The convention should be import pydp as dp rather than pd

@chinmayshah99 chinmayshah99 merged commit b30cbc1 into OpenMined:dev May 26, 2020
dvadym pushed a commit to dvadym/PyDP that referenced this pull request Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants