Skip to content

Fixed bug in docker file preventing creation of usable package#164

Merged
chinmayshah99 merged 1 commit intoOpenMined:devfrom
chinmayshah99:bugfix/docker-fix
May 31, 2020
Merged

Fixed bug in docker file preventing creation of usable package#164
chinmayshah99 merged 1 commit intoOpenMined:devfrom
chinmayshah99:bugfix/docker-fix

Conversation

@chinmayshah99
Copy link
Copy Markdown
Member

Added copying of .so file which was accidently removed. Also, moved installation from pipenv to pip

Pull Request

Description

Please include a summary of the change and which issue is fixed. If this closes one or more open issues, please tag them as described here.

Affected Dependencies

List any dependencies that are required for this change.

Type of Change

Please mark options that are relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation (non-breaking change which adds documentation)
  • Improvement (non-breaking change that improves the performance or reliability of existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

Additional Context

Please also include relevant motivation and context.

Added copying of .so file which was accidently removed. Also, moved installation from pipenv to pip
@chinmayshah99 chinmayshah99 requested a review from simcof May 31, 2020 08:51
@chinmayshah99 chinmayshah99 added Severity: 1 - Critical 🔥 Causes a failure of the complete software system, subsystem or a program within the system Type: Bug 🐛 Some functionality not working in the codebase as intended labels May 31, 2020
@chinmayshah99 chinmayshah99 merged commit 9f59019 into OpenMined:dev May 31, 2020
@chinmayshah99 chinmayshah99 deleted the bugfix/docker-fix branch May 31, 2020 12:31
dvadym added a commit to dvadym/PyDP that referenced this pull request Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Severity: 1 - Critical 🔥 Causes a failure of the complete software system, subsystem or a program within the system Type: Bug 🐛 Some functionality not working in the codebase as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant