Utils Bindings#180
Merged
chinmayshah99 merged 8 commits intoOpenMined:devfrom Jun 21, 2020
Merged
Conversation
Member
Author
@chinmayshah99 I have added exceptions for the invalid operations. |
| util.def("vector_filter", &dp::VectorFilter<double>); | ||
| util.def("vector_to_string", &dp::VectorToString<double>); | ||
| util.def("round_to_nearest_multiple", &dp::RoundToNearestMultiple); | ||
| // TODO: Throw an exception in case the function returns false. |
Member
There was a problem hiding this comment.
@codeboy5 can you remove this comment if it's done already or is it left as a future exercise?
Member
|
@codeboy5 if it's no longer WIP, can we remove the tag from the PR title? |
Member
Author
Yes I think this is done from my side! |
chinmayshah99
approved these changes
Jun 21, 2020
BenjaminDev
pushed a commit
to BenjaminDev/PyDP
that referenced
this pull request
Jul 3, 2020
changed import Clone submodules as well so we can peg to a SHA and not break unexpectedly. Include python 3.5 in build images remove 3rd party from ignore and clone the submodule instead. Remove cloning 3rd party deps as it was not pegged to a SHA or version. Using git submodule to ensure we pull in the correct version of 3rd code. explicity stated the pipenv place the venv inside the project dir. Set env vars to the appropriate virtual env so users can simply run updated python version arg to upper case remove debugging debugging GITHUB_SHA debugging GITHUB_SHA removed debugging added git checkout for sub-mod to specific version style fix changed import fix typo in dockerfile added checks for python, bazel & pipenv install bazel using binary installer switched back add check pipenv for linux (OpenMined#160) * add check for pipenv * Update prereqs_linux.sh * replace apt with pip * use python -c to check if pipenv is installed * use pip3 and python3 * call python instead of python3 * use python3 instead of python * check pythong using --version * add elif to double check python Utils Bindings (OpenMined#180) * utils bindings * style fix * more bindings and tests * more bindings and tests * bindings for add,subtract and sqaure * style fix and TODO added * throwing runtime error during invalid operations * removed TODO Added Docker hub publish (OpenMined#176) * added github workflow to publish the docker image. Runs test suit as a sanity check. * Update update-docker-image.yml * Update update-docker-image.yml * Update update-docker-image.yml * Update update-docker-image.yml * added builds for all python versions. * syntax * formatting remove spaces. * testing * shuffle the image name concatenation. * need to references from steps level * need to references from steps level * Fix docker args. hyphens are illegal it seems. * WIP. need to version upstream deps like thet base dp lib from google. Otherwise all our stuff will break unexpectedly. Better to formally pull in deps. However, I see doesn't have any releases yet. * Clone submodules as well so we can peg to a SHA and not break unexpectedly. Include python 3.5 in build images * remove 3rd party from ignore and clone the submodule instead. * Remove cloning 3rd party deps as it was not pegged to a SHA or version. Using git submodule to ensure we pull in the correct version of 3rd code. * explicity stated the pipenv place the venv inside the project dir. Set env vars to the appropriate virtual env so users can simply run * updated python version arg to upper case * remove debugging * debugging GITHUB_SHA * debugging GITHUB_SHA * removed debugging * added docker publish stuff * added third_party yet again to docker file It made sense, as people using docker for development already have third-party folder cloned. * disabled docker hub push on every release Co-authored-by: Chinmay Shah <chinmayshah3899@gmail.com> Added error handling (OpenMined#188) * added bascic exception handling * added error handling for bounded functions * added error handling for order statistics * fixed cpp style fixing issue OpenMined#92 clang-format added sample error handling code 0.1.3 release ready Update update-docker-image.yml changes in sha version of DP library docker tagging fix Update update-docker-image.yml 0.1.3 -> 0.1.4 added docker publish stuff added third_party yet again to docker file It made sense, as people using docker for development already have third-party folder cloned. disabled docker hub push on every release
dvadym
pushed a commit
to dvadym/PyDP
that referenced
this pull request
Jul 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
I have added a binding for
meanfunction. Also added a test intest_util.py. @chinmayshah99 is this okay?Affected Dependencies
List any dependencies that are required for this change.
Type of Change
Please mark options that are relevant.
How has this been tested?
pytest testsChecklist
Additional Context
Includes bindings for #27