Skip to content

GeometricDistribution and fixed LaplaceDistribution#205

Merged
chinmayshah99 merged 2 commits intoOpenMined:devfrom
BenjaminDev:distributions-only
Jul 30, 2020
Merged

GeometricDistribution and fixed LaplaceDistribution#205
chinmayshah99 merged 2 commits intoOpenMined:devfrom
BenjaminDev:distributions-only

Conversation

@BenjaminDev
Copy link
Copy Markdown
Member

Description

  1. Added GeometricDistribution and fixed LaplaceDistribution.
  2. Added more tests (I'm still unsure how we should be testing these bindings current coverage is poor)
  3. Added sphinx style docstrings to all functions I touched. These can be used to generate docs. PR for sphinx setup coming.
  4. Updated the git submodule sha to match docker and setup scripts.

Affected Dependencies

None.

How has this been tested?

  • pytest on python 3.7 all tests pass.

Checklist

@chinmayshah99
Copy link
Copy Markdown
Member

chinmayshah99 commented Jul 30, 2020

Creating an issue for the test that fails #213

@chinmayshah99 chinmayshah99 merged commit 25bf86a into OpenMined:dev Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants