Run clang-format from the system installation instead of pipenv#216
Merged
chinmayshah99 merged 3 commits intoOpenMined:devfrom Aug 2, 2020
Merged
Run clang-format from the system installation instead of pipenv#216chinmayshah99 merged 3 commits intoOpenMined:devfrom
chinmayshah99 merged 3 commits intoOpenMined:devfrom
Conversation
Member
|
Is installing clang-format part of |
Member
Author
It was never a part of it, we could update it tho. |
Member
|
Please do |
chinmayshah99
approved these changes
Aug 1, 2020
chinmayshah99
approved these changes
Aug 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes clang-format as a Pip dependency and updates the Makefile to run clang-format from the system clang-format installation.
Fixes #215
Affected Dependencies
List any dependencies that are required for this change.
How has this been tested?
Running
make format-style-cppdoes work.Checklist