[WIP] Refactoring: Bounded functions#223
Merged
chinmayshah99 merged 1 commit intoOpenMined:test-capifrom Aug 6, 2020
Merged
Conversation
dvadym
added a commit
to dvadym/PyDP
that referenced
this pull request
Jul 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Here I share a continuation of the algorithm builder class, now having reduced the boundend functions bindings to a utility function and a templated declaration function. The code compiles but it is no yet working, as for any configuration it always returns 0 as result. The advantage should be that now the computations issue can be solved in one place to make it work for all bounded functions.
How has this been tested?
Manual test
Checklist