Order statistics refactor#244
Merged
chinmayshah99 merged 16 commits intoOpenMined:test-capifrom Aug 14, 2020
Merged
Conversation
…nto review-ale-refactor
…view-ale-refactor
…der-statistics-refactor
…k but need to avoid name clashes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes:
builderto handle theorder-statistics(Max, Min, Median and Percentile).builderto select the appropriate return types.base_percentileas there was a name clash and as far as I can see it's not DP.pytest tests/you should see green!Affected Dependencies
None.
How has this been tested?
pytest tests/52 passing tests.Checklist