Skip to content

Order statistics refactor#244

Merged
chinmayshah99 merged 16 commits intoOpenMined:test-capifrom
BenjaminDev:order-statistics-refactor
Aug 14, 2020
Merged

Order statistics refactor#244
chinmayshah99 merged 16 commits intoOpenMined:test-capifrom
BenjaminDev:order-statistics-refactor

Conversation

@BenjaminDev
Copy link
Copy Markdown
Member

Description

Changes:

  1. Modified the builder to handle the order-statistics (Max, Min, Median and Percentile).
  2. Modified the builder to select the appropriate return types.
  3. Removed the old capi files and folder and from the build file.
  4. Removed the old base_percentile as there was a name clash and as far as I can see it's not DP.
  5. Updated the upstream ref.
  6. Added the order statistics to the python interface.
  7. Updated and reinstated the tests. All tests pass (however, the CI references an older upstream ref and so the might fail there) But once checked out running pytest tests/ you should see green!

Affected Dependencies

None.

How has this been tested?

  • pytest tests/ 52 passing tests.

Checklist

@chinmayshah99 chinmayshah99 merged commit 0ff3ca8 into OpenMined:test-capi Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants