Improve makefile actions#272
Merged
chinmayshah99 merged 1 commit intoOpenMined:devfrom Aug 27, 2020
Merged
Conversation
alejandrosame
added
the
Type: Improvement 📈
chinmayshah99
approved these changes
Aug 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While working on fixing #268 and adding new tests, I noticed that the current Makefile
buildandinstallactions were failing. This PR updates the Makefile for a smoother dev experience. These issues are never raised during CI testing because we always make fresh installations.Affected Dependencies
No dependencies changed.
How has this been tested?
I executed the changed actions manually:
make buildnow can run multiple times even whenbuild_PyDP.shis not updated.make installnow properly reinstalls PyDP package in the current pipenv environment.make installchanges do not brakemake testaction.Checklist