Refactor OpenMined PyDP README#279
Merged
chinmayshah99 merged 2 commits intoOpenMined:devfrom Aug 29, 2020
8bitmp3:patch-1
Merged
Refactor OpenMined PyDP README#279chinmayshah99 merged 2 commits intoOpenMined:devfrom 8bitmp3:patch-1
chinmayshah99 merged 2 commits intoOpenMined:devfrom
8bitmp3:patch-1
Conversation
chinmayshah99
requested changes
Aug 28, 2020
Member
chinmayshah99
left a comment
There was a problem hiding this comment.
We made changes to the packaging structure but never updated the readme. Can you please make these changes?
Member
|
Hey @8bitmp3 these suggestions look great. Can these be conceptualized and put into contributing guidelines? |
Contributor
Author
|
Thank and no worries @chinmayshah99 ! For Contributing, we can add a short style guide later down the road. It's a great idea. |
chinmayshah99
approved these changes
Aug 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @chinmayshah99 ! I went though the OpenMined PyDP README and introduced some improvements. Let me know what you think.
The PyDP background section
The Installation section
pipmanager -> as in: use PiPy to "pip install", so to speakChange the title from "Usage" to "Examples"
Add an explanation to the
dev/exampleslink, such as "Curated list of tutorials and sample code for PyDP", instead of just saying "this example"Change "Jupyer Notebook" [typo] -> "An introduction to PyDP (a Jupyter notebook)"
Rephrase: "for use via code explanation..." (it sounded a bit strange) -> "To get started..."
Rephrase "a sample of usage" -> "Example: calculate the Bounded Mean" (more specific)
Refactor code comments:
Cosmetic changes:
Check out this fairly recent paper: Deep Learning with Differential Privacy (July 28, 2020): https://www.arxiv-vanity.com/papers/1607.00133/ (OpenAI/Google)
Major diffs: