Skip to content
This repository was archived by the owner on May 18, 2019. It is now read-only.

Fix runtime CFLAGS detection#2371

Closed
sjoelund wants to merge 1 commit intoOpenModelica:masterfrom
sjoelund:real-fnodollars
Closed

Fix runtime CFLAGS detection#2371
sjoelund wants to merge 1 commit intoOpenModelica:masterfrom
sjoelund:real-fnodollars

Conversation

@sjoelund
Copy link
Copy Markdown
Member

@sjoelund sjoelund commented Apr 17, 2018

The old code only worked for some combinations of CFLAGS. It did not
actually find -fno-dollars-in-identifiers.

@OpenModelica-Hudson
Copy link
Copy Markdown
Member

OpenModelica-Hudson commented Apr 17, 2018

The test suite is unstable according to OpenModelica_TEST_PULL_REQUEST 2018-04-17_07-44-14.

@sjoelund
Copy link
Copy Markdown
Member Author

sjoelund commented Apr 17, 2018

@wibraun would it be possible to stop using macros the symbolic Jacobian code? Or at least stop using dollars in the identifiers?

@sjoelund
Copy link
Copy Markdown
Member Author

sjoelund commented Apr 17, 2018

I think we could just use System.unquoteIdentifier instead. I'll look into it...

@OpenModelica-Hudson
Copy link
Copy Markdown
Member

OpenModelica-Hudson commented Apr 17, 2018

The test suite is unstable according to OpenModelica_TEST_PULL_REQUEST 2018-04-17_08-35-19.

@OpenModelica-Hudson
Copy link
Copy Markdown
Member

OpenModelica-Hudson commented Apr 17, 2018

The job failed to compile; for details, see OpenModelica_TEST_PULL_REQUEST 2018-04-17_09-23-06.

@OpenModelica-Hudson
Copy link
Copy Markdown
Member

OpenModelica-Hudson commented Apr 17, 2018

The job failed to compile; for details, see OpenModelica_TEST_PULL_REQUEST 2018-04-17_09-37-20.

@wibraun
Copy link
Copy Markdown
Member

wibraun commented Apr 17, 2018

Yes, we can stop using macros in symbolic jacobian. I'll can try to do so.

@sjoelund
Copy link
Copy Markdown
Member Author

sjoelund commented Apr 25, 2018

Variables beginning with $ will now be quoted in the same way that variables beginning with ' are quoted. Of course, the C-code becomes unreadable anyway, so we might as well point directly to some array index but at least on some platforms where the linker does not support $ in variable names, we can now compile models.

@OpenModelica-Hudson
Copy link
Copy Markdown
Member

OpenModelica-Hudson commented Apr 25, 2018

The test suite is unstable according to OpenModelica_TEST_PULL_REQUEST 2018-04-25_10-52-19.

@OpenModelica-Hudson
Copy link
Copy Markdown
Member

OpenModelica-Hudson commented Apr 25, 2018

The test suite is unstable according to OpenModelica_TEST_PULL_REQUEST 2018-04-25_11-20-37.

@OpenModelica-Hudson
Copy link
Copy Markdown
Member

OpenModelica-Hudson commented Apr 25, 2018

The test suite is unstable according to OpenModelica_TEST_PULL_REQUEST 2018-04-25_12-41-22.

@OpenModelica-Hudson
Copy link
Copy Markdown
Member

OpenModelica-Hudson commented Apr 25, 2018

The test suite is unstable according to OpenModelica_TEST_PULL_REQUEST 2018-04-25_13-33-58.

@OpenModelica-Hudson
Copy link
Copy Markdown
Member

OpenModelica-Hudson commented Apr 2, 2019

The test suite is unstable according to OpenModelica_TEST_PULL_REQUEST 2019-04-02_09-02-54.

@OpenModelica-Hudson
Copy link
Copy Markdown
Member

OpenModelica-Hudson commented Apr 2, 2019

The test suite is unstable according to OpenModelica_TEST_PULL_REQUEST 2019-04-02_11-28-47.

@sjoelund
Fix runtime CFLAGS detection
3685fba 
The old code only worked for some combinations of CFLAGS. It did not
actually find -fno-dollars-in-identifiers.
@OpenModelica-Hudson
Copy link
Copy Markdown
Member

OpenModelica-Hudson commented Apr 2, 2019

The tests run correctly according to OpenModelica_TEST_PULL_REQUEST 2019-04-02_13-16-48.

OpenModelica-Hudson pushed a commit that referenced this pull request Apr 2, 2019
@sjoelund @OpenModelica-Hudson
Fix runtime CFLAGS detection
5de59c3 
The old code only worked for some combinations of CFLAGS. It did not
actually find -fno-dollars-in-identifiers.

Belonging to [master]:
  - #2371
@OpenModelica-Hudson
Copy link
Copy Markdown
Member

OpenModelica-Hudson commented Apr 2, 2019

Wrong hash OMCompiler 3685fba d0c8da1

@sjoelund sjoelund deleted the real-fnodollars branch April 2, 2019 11:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sjoelund @OpenModelica-Hudson @wibraun