Skip to content
This repository was archived by the owner on May 18, 2019. It is now read-only.

Use Autoconf.mo instead of external C functions#3016

Closed
sjoelund wants to merge 1 commit intoOpenModelica:masterfrom
sjoelund:no-external-config
Closed

Use Autoconf.mo instead of external C functions#3016
sjoelund wants to merge 1 commit intoOpenModelica:masterfrom
sjoelund:no-external-config

Conversation

@sjoelund
Copy link
Copy Markdown
Member

This starts using Autoconf.mo for constants such as the dll extension.

@OpenModelica-Hudson
Copy link
Copy Markdown
Member

The test suite is unstable according to OpenModelica_TEST_PULL_REQUEST 2019-03-29_10-36-01.

This starts using Autoconf.mo for constants such as the dll extension.
@sjoelund sjoelund force-pushed the no-external-config branch from 14a664d to d2aaba1 Compare March 29, 2019 10:16
@OpenModelica-Hudson
Copy link
Copy Markdown
Member

The test suite is unstable according to OpenModelica_TEST_PULL_REQUEST 2019-03-29_11-17-52.

@OpenModelica-Hudson
Copy link
Copy Markdown
Member

The tests run correctly according to OpenModelica_TEST_PULL_REQUEST 2019-03-29_11-49-30.

OpenModelica-Hudson pushed a commit that referenced this pull request Mar 29, 2019
This starts using Autoconf.mo for constants such as the dll extension.

Belonging to [master]:
  - #3016
  - OpenModelica/OpenModelica-testsuite#1154
OpenModelica-Hudson pushed a commit to OpenModelica/OpenModelica-testsuite that referenced this pull request Mar 29, 2019
@sjoelund sjoelund deleted the no-external-config branch March 29, 2019 11:19
@adrpo
Copy link
Copy Markdown
Member

adrpo commented Mar 29, 2019

Why is this even working? In windows it does not work properly. We build the bootstrapped compiler out of the tar.gz C files and they expect the Compiler/runtime library to contain the functions that are called from System.c

@adrpo
Copy link
Copy Markdown
Member

adrpo commented Mar 29, 2019

So in windows the build just dies with:

make -f Makefile.omdev.mingw Makefile.sources
make[6]: Entering directory '/c/home/adrpo33/dev/OpenModelica/OMCompiler/Compiler/boot'
/c/home/adrpo33/dev/OpenModelica/build/bin/omc.exe -g=MetaModelica -n=1 MakeSources.mos
We could not find any of:
        C:/home/adrpo33/dev/OpenModelica/build/MinGW/bin and C:/home/adrpo33/dev/OpenModelica/build/MinGW/libexec/gcc/mingw32/4.4.0
        $OMDEV/tools/MinGW/bin and $OMDEV/tools/MinGW/libexec/gcc/mingw32/4.4.0
Error processing file: MakeSources.mos
[C:\home\adrpo33\dev\OpenModelica\OMCompiler\Compiler\boot\MakeSources.mos:1:1-1:36:writable] Error: Class runScript not found in scope <global scope> (looking for a function or record).
[C:\home\adrpo33\dev\OpenModelica\OMCompiler\Compiler\boot\MakeSources.mos:2:1-2:15:writable] Error: Class mkdir not found in scope <global scope> (looking for a function or record).
[C:\home\adrpo33\dev\OpenModelica\OMCompiler\Compiler\boot\MakeSources.mos:3:1-3:19:writable] Error: Class cd not found in scope <global scope> (looking for a function or record).

# Error encountered! Exiting...
# Please check the error message and the flags.

@adrpo
Copy link
Copy Markdown
Member

adrpo commented Mar 29, 2019

I cannot even debug this properly as we only have C files, not .mo files they were created from.

@adrpo
Copy link
Copy Markdown
Member

adrpo commented Mar 29, 2019

Nevermind, I found the problem, #3020 should fix it.

@hkiel
Copy link
Copy Markdown
Member

hkiel commented Apr 2, 2019

@adrpo Now OSX fails:

gmake[5]: Entering directory '/Users/om/src/OpenModelica/OMCompiler/Compiler/boot'
/Users/om/src/OpenModelica/build/bin/omc -g=MetaModelica -n=1 build/UnitChecker.stamp.mo.mos
We could not find any of:
	/Users/om/src/OpenModelica/build/MinGW/bin and /Users/om/src/OpenModelica/build/MinGW/libexec/gcc/mingw32/4.4.0
	$OMDEV/tools/MinGW/bin and $OMDEV/tools/MinGW/libexec/gcc/mingw32/4.4.0

@hkiel
Copy link
Copy Markdown
Member

hkiel commented Apr 3, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants