[ModelicaSystem*] add timeout argument #382
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syntron
force-pushed
the
ModelicaSystem_timeout
branch
from
ecd996f to
d37ec0b
Compare
adeas31
requested changes
Nov 25, 2025
Member
adeas31
left a comment
adeas31
left a comment
There was a problem hiding this comment.
ModelicaSystemDoE and ModelicaSystem doesn't really need timeout. The timeout is used by OMCSessionZMQ so it is better to expose timeout with API so it can be set to something else other than default 10s.
I also saw that timeout is used very randomly in the code. For starting omc we are using timeout of 2s and then each process class also uses timeout. It is also used for command execution. Perhaps its better to clean up the code and use timeout properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add / fix argument timeout to / of ModelicaSystem and ModelicaSystemDoE