Skip to content

do not write data twice to override file in linearize()#461

Merged
adeas31 merged 2 commits intoOpenModelica:maintenance/v4.0from
syntron:v4.0_fix
Apr 15, 2026
Merged

do not write data twice to override file in linearize()#461
adeas31 merged 2 commits intoOpenModelica:maintenance/v4.0from
syntron:v4.0_fix

Conversation

@syntron
Copy link
Copy Markdown
Contributor

@syntron syntron commented Apr 14, 2026

see title; override data is handled twice

@syntron
Copy link
Copy Markdown
Contributor Author

syntron commented Apr 14, 2026

I'm lost why this fails ... it has to be connected with the conversion 'solver' => 's' as #456 was working well (see: #456 (comment)); however, I'm currently without the right test environment to vary the setup; based on the pytest output, it gets a command line containing '-s=1.0' for stopTime = 1.0:

stopTime = 1.0
and
mod.setSimulationOptions(simOptions={"stopTime": stopTime})
result in
E OMPython.ModelicaSystem.ModelicaSystemError: Error running command ['/tmp/tmpm6n2_nsv/M_getters', '-overrideFile=/tmp/tmpm6n2_nsv/M_getters_res_override.txt', '-r=/tmp/tmpm6n2_nsv/M_getters_res.mat', '-s=1.0']

@adeas31
Copy link
Copy Markdown
Member

adeas31 commented Apr 14, 2026

I'm lost why this fails ... it has to be connected with the conversion 'solver' => 's' as #456 was working well (see: #456 (comment)); however, I'm currently without the right test environment to vary the setup; based on the pytest output, it gets a command line containing '-s=1.0' for stopTime = 1.0:

stopTime = 1.0 and mod.setSimulationOptions(simOptions={"stopTime": stopTime}) result in E OMPython.ModelicaSystem.ModelicaSystemError: Error running command ['/tmp/tmpm6n2_nsv/M_getters', '-overrideFile=/tmp/tmpm6n2_nsv/M_getters_res_override.txt', '-r=/tmp/tmpm6n2_nsv/M_getters_res.mat', '-s=1.0']

Probably because @adrpo mistakenly pushed in a bad fix. But now is fixed so this should work fine.

@adeas31 adeas31 merged commit 7267525 into OpenModelica:maintenance/v4.0 Apr 15, 2026
35 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants