Merged
Conversation
- We now have cmake3 installed on our CentOS images. Use that when
building OMSimulator.
- So we can just install cmake3 on it.
- If this was not done intentionally, it should probably use the one
used by OpenModelica CI as well, i.e,
`docker.openmodelica.org/build-deps:el7.amd64`
8151dfb to
2b53541
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
None
Purpose
Change CI builds on CentOS7 to use cmake3 (CMake versions > 3)
Approach
We now have cmake3 installed on OpenModelica's CentOS7 docker images. However, OMSimulator does not actually use those and uses the clean base centos:7 image. So just install cmake3 on that one as well.
Commits
@mahge
Use cmake3 on CentOS7.
71710a0
building OMSimulator.
@mahge
OMSimulator uses its own clean CentOS7 image.
2b53541
So we can just install cmake3 on it.
If this was not done intentionally, it should probably use the one
used by OpenModelica CI as well, i.e,
docker.openmodelica.org/build-deps:el7.amd64@mahge
Add epel repo for cmake3 package.
b18cd34