Include cmath explicitly.#1091
Merged
lochel merged 2 commits intoOpenModelica:masterfrom Oct 28, 2021
Merged
Conversation
- The file uses std::isnan and std::isinf from cmath.
- It breaks on old compilers (e.g. gcc-5) because the header might not
be included indirectly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
None
Purpose
The file src/OMSimulatorLib/ComponentFMUCS.h uses
std::isnanandstd::isinffrom <cmath> without including the header.Compilation of OMSimulator breaks on old compilers (e.g. gcc-5) because the header might not be included indirectly.
Approach
Include the header explictly.