Set install component when part of OpenModelica.#1251
Merged
mahge merged 1 commit intoOpenModelica:masterfrom Sep 5, 2023
Merged
Set install component when part of OpenModelica.#1251mahge merged 1 commit intoOpenModelica:masterfrom
mahge merged 1 commit intoOpenModelica:masterfrom
Conversation
- When OMSimulator is built as part of OpenModelica, set the install
component to `omsimulator` for all targets built by it.
OpenModelica has multiple install components and so this needs to be
set as well. Otherwise CMake will put it under the 'unknown' install
componet it creates autoamatically.
- This can be changed to be set always (even when not part of OpenModelica)
It should work just fine as well. For now, it is set only when it is
actually required (i.e, OMsimulator is part of OpenModelica.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When OMSimulator is built as part of OpenModelica, set the install component to
omsimulatorfor all targets built by it. OpenModelica has multiple install components and so this needs to be set as well. Otherwise CMake will put it under the 'unknown' install component it creates automatically.This can be changed to be set always (even when not part of OpenModelica) It should work just fine as well. For now, it is set only when it is actually required (i.e, OMsimulator is part of OpenModelica.)