Implement State Event Detection#1341
Merged
lochel merged 34 commits intoOpenModelica:masterfrom Nov 19, 2024
Merged
Conversation
lochel
added a commit
to lochel/OMSimulator
that referenced
this pull request
Nov 20, 2024
lochel
added a commit
that referenced
this pull request
Nov 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Purpose
OMSimulator previously only supported time events and checked event-triggering conditions (zero-crossings) only at communication time steps, without identifying the exact time at which an event occurred. This limitation could delay event handling by up to one time step, impacting the accuracy of simulations where precise event timing is critical. This PR introduces state event detection mechanism, allowing the simulation to detect and handle events more accurately by narrowing down the exact moment a zero-crossing occurs.