Skip to content

Add SRMD validation and schema support#1417

Merged
lochel merged 24 commits intoOpenModelica:maintenance/v2.1from
aminbajand:feature/1408-support-srmd-schema-check
Feb 7, 2025
Merged

Add SRMD validation and schema support#1417
lochel merged 24 commits intoOpenModelica:maintenance/v2.1from
aminbajand:feature/1408-support-srmd-schema-check

Conversation

@aminbajand
Copy link
Copy Markdown

Pull Request: Add SRMD Schema Validation to OMSimulator


Description

This pull request addresses #1408 by introducing validation for SRMD files (.srmd) against the SSP Traceability Schema. Validation is performed during import and addResource operations.


Key Changes

  1. SRMD Validation:

    • Extended the existing XML validation framework to support .srmd files.
    • Integrated SimulationResourceMetaData.xsd schema for SRMD validation.
  2. Schema Updates:

    • Replaced xs:dateTimeStamp with a custom dateTimeStampType in SSPTraceabilityCommon.xsd for compatibility with XML Schema 1.0.
  3. Testing:

    • Added invalidSRMD.py to test:
      • Validation of model contains SRMD file that @robha67 provides in here

Related Issue

Closes #1408.

@aminbajand aminbajand requested review from adrpo and arun3688 January 10, 2025 12:05
@aminbajand aminbajand self-assigned this Jan 10, 2025
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jan 10, 2025

CLA assistant check
All committers have signed the CLA.

@arun3688 arun3688 requested a review from lochel January 10, 2025 12:14
@arun3688
Copy link
Copy Markdown
Contributor

@just-amin add the tests to the resources and also to Makefile

Comment thread src/OMSimulatorLib/Model.cpp Outdated
Copy link
Copy Markdown
Member

@adrpo adrpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@aminbajand
Copy link
Copy Markdown
Author

@lochel @arun3688
I believe that everything is okay with merging this part. Other than changing the SRMD sample that could be another issue and it's not related to this issue for now.

@lochel lochel merged commit 3a9f801 into OpenModelica:maintenance/v2.1 Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants