Quote signal names in CSV output#1528
Merged
arun3688 merged 1 commit intoOpenModelica:masterfrom Oct 28, 2025
Merged
Conversation
FMUs with the structured variable naming convention may contain comma signs in the signal names. For example: * system.root.example.x[1,1], or * system.root.example.der(y, 2). If these signal names are not quoted, the output CSV files can not be parsed by other tools, e.g. OMEdit. Therefore, OMSimulator should quote signal names in CSV output, ensuring that CSV output is correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
#1197
Purpose
FMUs with the structured variable naming convention may contain comma signs in the signal names. For example:
system.root.example.x[1,1], orsystem.root.example.der(y, 2).If these signal names are not quoted, the output CSV files can not be parsed by other tools, e.g. OMEdit. Therefore, OMSimulator should quote signal names in CSV output, ensuring that CSV output is correct.
Approach
This PR updates CSVWriter to quote signal names when writing the header.