Accept int64 VtValue for TYPE_INT with checked narrowing - Houdini 21#4
Open
rolledhand wants to merge 1 commit intoOpenMoonRay:mainfrom
Open
Accept int64 VtValue for TYPE_INT with checked narrowing - Houdini 21#4rolledhand wants to merge 1 commit intoOpenMoonRay:mainfrom
rolledhand wants to merge 1 commit intoOpenMoonRay:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compatibility:
build
Issues/Tickets:
Release notes comment:
Fixes Houdini 21 SceneVariables integer conversion by accepting 64-bit integer inputs for
TYPE_INTattributes inValueConverter.Comments for the reviewer:
lib/hydramoonray/ValueConverter.cc.__SceneVariables__attributes that expectTYPE_INT.__SceneVariables__.* cannot convert long long to IntIntTYPE_INTconversion behavior is updatedLook or scene setup change:
No intended look change. This is a Houdini/MoonRay value-conversion compatibility fix.
Special notes for production:
long long -> Intconversion failures for SceneVariables in Houdini 21.Attention/Reviewers:
Checklist: