Double includes

[gonsolo]

You might want to remove double includes:

gonsolo src:find . -type f \( -name "*.cpp" -o -name "*.c" -o -name "*.hpp" -o -name "*.h" \) | while read file; do   duplicates=$(grep "^#include" "$file" | sort | uniq -c | grep -v '^\s*1 ');   if [ ! -z "$duplicates" ]; then     echo "--- Duplicates found in $file ---";     echo "$duplicates";     echo "---------------------------------";   fi; done
--- Duplicates found in ./openmoonray/moonray/moonray_arras/mcrt_computation/lib/engine/mcrt/McrtUpdate.h ---
      2 #include <functional>
---------------------------------
--- Duplicates found in ./openmoonray/moonray/moonray/cmd/point_generation_cmd/PerfectPowerArray.h ---
      2 #include <type_traits>
---------------------------------
--- Duplicates found in ./openmoonray/moonray/moonray/cmd/point_generation_cmd/Array.h ---
      2 #include <type_traits>
---------------------------------
--- Duplicates found in ./openmoonray/moonray/moonray/lib/rendering/shading/Util.h ---
      2 #include <moonray/rendering/shading/ispc/Util_ispc_stubs.h>
---------------------------------
--- Duplicates found in ./openmoonray/moonray/moonray/lib/common/mcrt_util/Wait.h ---
      2 #include <climits>
      2 #include <sys/syscall.h>
      2 #include <unistd.h>
---------------------------------
--- Duplicates found in ./openmoonray/moonray/scene_rdl2/lib/render/util/ReaderWriterMutex.h ---
      2 #include <mutex>
---------------------------------
--- Duplicates found in ./openmoonray/moonray/scene_rdl2/lib/common/grid_util/ShmData.h ---
      2 #include <cstdint>
---------------------------------
--- Duplicates found in ./openmoonray/moonray/scene_rdl2/lib/common/platform/Platform.h ---
      2 #include <cstdint>
---------------------------------
--- Duplicates found in ./openmoonray/moonray/scene_rdl2/lib/common/platform/Intrinsics.h ---
      2 #include <immintrin.h>
---------------------------------
--- Duplicates found in ./openmoonray/moonray/scene_rdl2/lib/common/math/Math.h ---
      2 #include <cmath>
      2 #include <float.h>
---------------------------------
--- Duplicates found in ./openmoonray/moonray/scene_rdl2/lib/scene/rdl2/rdl2.h ---
      2 #include "Displacement.h"
---------------------------------
--- Duplicates found in ./openmoonray/moonray/scene_rdl2/lib/scene/rdl2/Map.h ---
      2 #include <scene_rdl2/common/platform/Platform.h>
---------------------------------

[jmahovsky-dwa]

Thanks for telling us about these!

[jmahovsky-dwa]

We have fixed these.

[gonsolo]

Cool.

Have you seen these:
OpenMoonRay/scene_rdl2#11
OpenMoonRay/mcrt_dataio#5
OpenMoonRay/mcrt_dataio#6

[jmahovsky-dwa]

Thanks, we'll fix these.