Skip to content

[com1]: add option to only save certain particle props#1273

Merged
fso42 merged 2 commits into
masterfrom
addIndCells
May 18, 2026
Merged

[com1]: add option to only save certain particle props#1273
fso42 merged 2 commits into
masterfrom
addIndCells

Conversation

@awirb
Copy link
Copy Markdown
Contributor

@awirb awirb commented May 11, 2026

No description provided.

@awirb awirb requested a review from fso42 May 11, 2026 12:51
@qltysh
Copy link
Copy Markdown
Contributor

qltysh Bot commented May 11, 2026

Analysis for project AvaFrame

❌ 1 blocking issue (1 total)

Tool Category Rule Count
black Style Incorrect formatting, autoformat by running qlty fmt. 1

@qltysh one-click actions:

  • Auto-fix formatting (qlty fmt && git push)

Comment thread avaframe/com1DFA/com1DFA.py
@fso42 fso42 added the enhancement New feature or request label May 11, 2026
Comment thread avaframe/com1DFA/com1DFACfg.ini
Comment thread avaframe/com1DFA/com1DFA.py Outdated
Comment thread avaframe/com1DFA/com1DFA.py Outdated
Comment thread avaframe/com1DFA/com1DFA.py
Comment thread avaframe/com1DFA/com1DFA.py Outdated
@awirb awirb requested a review from fso42 May 13, 2026 09:06
@qltysh
Copy link
Copy Markdown
Contributor

qltysh Bot commented May 13, 2026

Qlty


Coverage Impact

⬆️ Merging this pull request will increase total coverage on master by 0.03%.

Modified Components (1)

RatingComponent% Diff
Coverage rating: C Coverage rating: C
com1DFA100.0%

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
Coverage rating: B Coverage rating: B
avaframe/com1DFA/com1DFA.py100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@awirb awirb changed the title add option to only save certain particle props [com1]: add option to only save certain particle props May 15, 2026
Comment thread avaframe/com1DFA/com1DFACfg.ini
Comment thread avaframe/com1DFA/com1DFA.py Outdated
Comment thread avaframe/com1DFA/com1DFA.py
awirb and others added 2 commits May 18, 2026 12:15
check for particle properties, rename key
add pytest
…function

- Introduced `_buildParticlePropertiesFilter` to centralize key validation and filtering logic.
- Simplified `savePartToPickle` by reusing the new helper function, improving readability.
- Replaced `AttributeError` with `KeyError` for invalid properties to better signify the issue.
@fso42 fso42 assigned fso42 and unassigned awirb May 18, 2026
@fso42
Copy link
Copy Markdown
Contributor

fso42 commented May 18, 2026

Standardtests ident, apart from known com5SSL

@fso42 fso42 merged commit f8bbfe3 into master May 18, 2026
4 checks passed
@fso42 fso42 deleted the addIndCells branch May 18, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants